| Dalba added a comment. |
In T199615#4511856, @matej_suchanek wrote:Another problem I can see is that filter_unique (inside GenFact it is self._filter_unique) is used twice: it's provided to RecentChangesPageGenerator (line 821) and also used for dupfiltergen = self._filter_unique(gensList) (line 532). This means there are two same independent sets, one of which is redundant.
Could somebody verify the last sentence is a valid statement?
Yeah, it seems that it will happen if:
- using -recentchanges or -usercontribs
- and more than one generator is specified.
- and the -intersect option is not used.
I'll send a change request.
TASK DETAIL
EMAIL PREFERENCES
To: Dalba
Cc: gerritbot, zhuyifei1999, Xqt, Aklapper, matej_suchanek, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
Cc: gerritbot, zhuyifei1999, Xqt, Aklapper, matej_suchanek, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
