Xqt created this task.
Xqt added projects: Pywikibot, Pywikibot-weblinkchecker.py.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  **List of steps to reproduce**:
  
  - Add `self.threads.stop_all()` to weblinkchecker.py e.g. within this 
<https://gerrit.wikimedia.org/r/c/pywikibot/core/+/789854> at in line 623 
before the `break` statement.
  - run `pwb weblinkchecker -simulate -cat:Neapel`
  
  **What happens?**:
  
  The script fails with AttributeError because a `threading.Thread` does not 
have a` stop()` method
  
        self.exit()
      File "C:\pwb\GIT\core\pywikibot\bot.py", line 1484, in exit
        self.teardown()
      File ".\scripts\weblinkchecker.py", line 623, in teardown
        self.threads.stop_all()
      File "C:\pwb\GIT\core\pywikibot\tools\__init__.py", line 818, in stop_all
        thd.stop()
    AttributeError: 'LinkCheckThread' object has no attribute 'stop'. Did you 
mean: '_stop'?
    CRITICAL: Exiting due to uncaught exception <class 'AttributeError'>
  
  **Software version**:
  introduced with rPWBC4d756b3 
<https://phabricator.wikimedia.org/rPWBC4d756b3086fc864bed164e6d0266ac842d65b8f9>

TASK DETAIL
  https://phabricator.wikimedia.org/T307830

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Aklapper, pywikibot-bugs-list, Xqt, Jyoo1011, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to