Mpaa added a comment.
In T307830#7911218 <https://phabricator.wikimedia.org/T307830#7911218>, @Xqt wrote: > @Mpaa: I am unsure how to proceed. We could > > - keep the current implementation and add a warning to our documentation that the Thread object hast to be sublassed and provide a stop method if stop_all() is to be used (like ThreadedGenerator does) > - remove the stop_all method and stopping must be implemented outside the ThreadList class > - ignore AttributeError in stop_all() method and just write a debug message (and add a warning to our documentation) > > What do you suggest here? I agree with remove the stop_all method TASK DETAIL https://phabricator.wikimedia.org/T307830 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Mpaa Cc: jayvdb, Mpaa, Aklapper, pywikibot-bugs-list, Xqt, Fernandobacasegua34, 786, Suran38, Biggs657, Lalamarie69, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, Avicennasis, mys_721tx, Masti, Alchimista
_______________________________________________ pywikibot-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
