Xqt added a comment.

  @Geertivp: working on your script I found the following issues:
  
  1. there are related phabricator task described in the documentation (T282719 
<https://phabricator.wikimedia.org/T282719>, T214802 
<https://phabricator.wikimedia.org/T214802>, T208134 
<https://phabricator.wikimedia.org/T208134>, T138911 
<https://phabricator.wikimedia.org/T138911>, T20814 
<https://phabricator.wikimedia.org/T20814>). In which way are they related? Are 
they solved with your script or can they be solved with your script?
  2. what is the meaning/function of `mainlang` global variable (default 
description language)?
  3. shouldn't we move the "Known problems" and "To do" list from scripts 
documentation to a phabricator task (e.g. this one) that is is to be solved?
  4. Are all of the "Documentation" links related to this script? For example 
https://doc.wikimedia.org/pywikibot/master/ is related for the whole framework 
and I do not see any reason to mention it explicitly within the script 
documentation.
  5. What about running the script under Windows platform? Why is it necessary 
to notify those environment restrictions. Aren't they identical for all scripts 
and can be placed inside the documentation in a more general context?
  6. your code is under GNU v3.0 Licence. Pywikibot is licensend under MIT and 
the credits are made as a whole for each script or module like //(C) Pywikibot 
team, 2022, Distributed under the terms of the MIT license//. Authors are 
published in the AUTORS.rst file. Are you able to change the license of your 
contribution? This is not mandatory and it is ok keeping GNU but it needs to 
change the license documentation of the framework on several places which has 
to be done then.
  
  Any comments?

TASK DETAIL
  https://phabricator.wikimedia.org/T314942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Geertivp, Xqt
Cc: Xqt, LabDom, Aklapper, Geertivp, pywikibot-bugs-list, Alan_Ang-WMDE, 
PotsdamLamb, Jyoo1011, JohnsonLee01, Anasskoko, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Zambujo, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, Omar_sansi, mys_721tx, Daniel_Mietchen, jayvdb, 
Lydia_Pintscher, Masti, Alchimista
_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to