Geertivp added a comment.
1. I believe my script is actually solving T282719 <https://phabricator.wikimedia.org/T282719>, and I have been taking care to implement the required data quality rules (only loading validated data, not creating duplicate statements). The other tasks are loosely related to ISBN, and could be omitted from the script, when you feel the need. 2. The `mainlang` global variable is indeed the default description language, when the ISBN digital libraries would not return a language value. It determines in which language the label is written when creating a new instance. Therefore it is important to group ISBN numbers by language when exececuting the script, to ensure creating the label in the correct language. It is also used to search for items, and for displaying properties and items in the user language. - I would propose that you reinstate the original code line `inputfile = sys.stdin.read()`. This allowed to run the script for 1000s of ISBN numbers, when needed, on multiple lines (e.g. the full references section of any Wikipedia page containing ISBN numbers, via regex). - You changed it into: `inputfile = pywikibot.input('Get list of item numbers')`, which basically allows to process only 1 single ISBN number (one single input line), which I don't find a good solution... 3. I am currently working on "Known problems" like ensuring the inverse relationship between "Written work" and "Edition", making sure that the "Is a written work" and "Edition" statements exists at the level of Written work. - Other known problems can't be solved by the script, because they are caused by external, or complex internal data quality problems, and should stay. Examples: a Publisher is not found, because the statement "Is a publisher" was not assigned to its item. - Some other known problems could be moved to "To do", when they would require additional development. - I would personally want to add here another interesting functionality: "Implement a webservice on toolforge.org, based on the current shell script", accepting input from a textbox instead of from stdin. 4. The documentation links could be split into specific or general documentation (the general, non script specific documentation could also be removed -- I included it for myself to easily find the documentation). 5. The environment restrictions are indeed common for all Pywikibot scripts, so could be left out of the script. 6. Since I am still the only author at https://github.com/geertivp/Pywikibot I have changed the license to MIT. So you can change the license to MIT in the source code as well. Seems that MIT, as opposed to GPL, allows more freedom for commercial implementations, does not require publishing the code, and does not enforce keeping the same license. I will synchronise your and my changes in a future pull request. Thanks a lot for all your good work, and code review. TASK DETAIL https://phabricator.wikimedia.org/T314942 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Geertivp Cc: Xqt, LabDom, Aklapper, Geertivp, pywikibot-bugs-list, Alan_Ang-WMDE, PotsdamLamb, Jyoo1011, JohnsonLee01, Anasskoko, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Zambujo, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Omar_sansi, mys_721tx, Daniel_Mietchen, jayvdb, Lydia_Pintscher, Masti, Alchimista
_______________________________________________ pywikibot-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
