Xqt added a comment.

  I think this task is invalid because a DataSite is not a APISite but a 
subclass of it. The is_date_repository can either test for DataSite instance or 
for identity because we have all sites in pywikibot._sites (except there are 
different users). I am also unhabpy with the current Site comparison:
  
    import pywikibot
    class foo(pywikibot.tools.ComparableMixin):
        def _cmpkey(seld):
            return 'wikipedia', 'de'
        
    site = pywikibot.Site()
    bar = foo()
    site == bar
    True
  
  The later quacks like a duck but it is a frog!

TASK DETAIL
  https://phabricator.wikimedia.org/T85483

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Xqt, zhuyifei1999, matej_suchanek, TerraCodes, jayvdb, Ricordisamoa, 
Aklapper, pywikibot-bugs-list, Pietrodn, Lydia_Pintscher, XZise, PotsdamLamb, 
Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, 
Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, 
Masti, Alchimista
_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to