Tgr added a comment.
Thanks for investigating! The OAuth error for non-existent users was present from the start <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/73977/10/api/MWOAuthAPI.setup.php#96> (that was pre-Authmanager so I'm not sure how difficult it would have been at the time to autocreate the user), then got lifted <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/247717> into the AuthManager-aware version without any of us thinking about it. I think it's just wrong. We can probably just add autocreate to the basic grant, it seems harmless enough. Not sure about CentralAuth, the idea there (I think... it was a while ago <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/284499/comment/ae564743_cf95d337/>) was to prevent other providers which are not central account aware from messing things up, but this doesn't seem like the right way to do it. For autocreate on login it makes sense to disallow when the primary provider doing the login is not CentralAuth (although if that can happen at all, the wiki config probably has bigger problems). For autocreation during session initialization it doesn't make sense - CentralAuth-managed users will always log in via CentralAuth but there's no reason to expect that their sessions are always managed by CentralAuth. TASK DETAIL https://phabricator.wikimedia.org/T149672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
_______________________________________________ pywikibot-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
