jenkins-bot has submitted this change and it was merged.
Change subject: Replace useless string with FIXME
......................................................................
Replace useless string with FIXME
Change-Id: I208b9f20c7820804d83a73262a251de17b106397
---
M scripts/blockpageschecker.py
M scripts/welcome.py
2 files changed, 6 insertions(+), 12 deletions(-)
Approvals:
Nullzero: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/blockpageschecker.py b/scripts/blockpageschecker.py
index 23785c9..7e6a6e4 100755
--- a/scripts/blockpageschecker.py
+++ b/scripts/blockpageschecker.py
@@ -301,15 +301,13 @@
if show:
showQuest(page)
continue
- """
- # This check does not work :
+ # FIXME: This check does not work :
# PreloadingGenerator cannot set correctly page.editRestriction
# (see bug 55322)
- if not page.canBeEdited():
- pywikibot.output("%s is sysop-protected : this account can't edit "
- "it! Skipping..." % pagename)
- continue
- """
+ # if not page.canBeEdited():
+ # pywikibot.output("%s is sysop-protected : this account can't edit
"
+ # "it! Skipping..." % pagename)
+ # continue
restrictions = page.protection()
try:
editRestr = restrictions['edit']
diff --git a/scripts/welcome.py b/scripts/welcome.py
index c37a582..e48f194 100644
--- a/scripts/welcome.py
+++ b/scripts/welcome.py
@@ -718,11 +718,7 @@
if globalvar.quick and self.site.has_api():
us = [x for x in self.parseNewUserLog()]
showStatus()
- try:
- pywikibot.User.getall(self.site, us)
- except NotImplementedError:
- globalvar.quick = False
- us = self._parseNewUserLogOld()
+ pywikibot.User.getall(self.site, us)
else:
us = (pywikibot.User(self.site, users.user()) for users in
self.parseNewUserLog())
for users in us:
--
To view, visit https://gerrit.wikimedia.org/r/171274
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I208b9f20c7820804d83a73262a251de17b106397
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: Nullzero <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
