jenkins-bot has submitted this change and it was merged. Change subject: Remove user messages check during startup ......................................................................
Remove user messages check during startup 19703ab10826fdcd47c683d27ffe1ca1b2af0ac8 added a check to prevent user login during initalisation in order to log whether the user has unread messages on their talk page. The check used Site.logged_in, however that method will always be false at initialisation as _userinfo has not been fetched. (site.py:682 of https://mediawiki.org/wiki/Special:Code/pywikipedia/10285) Moving the user talk check to 'after' Site.login would complicate the login sequence, and has little benefit. A more comprehensive implementation is needed. So remove it for now, as it hasnt worked for a while. Bug: 69895 Change-Id: Id2c2321a8ebdd4edccb6c6f1731d7461dfd4fbd9 --- M pywikibot/bot.py 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve Nullzero: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/bot.py b/pywikibot/bot.py index 8fbf9ad..25280d4 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -317,16 +317,6 @@ log(u'SITE VERSION: %s' % site.version()) - # messages on bot discussion page? - if site.logged_in(): - if site.messages(): - messagestate = 'unanswered' - else: - messagestate = 'none' - else: - messagestate = 'unknown (not logged in)' - log(u'MESSAGES: %s' % messagestate) - log(u'=== ' * 14) -- To view, visit https://gerrit.wikimedia.org/r/157799 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2c2321a8ebdd4edccb6c6f1731d7461dfd4fbd9 Gerrit-PatchSet: 6 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg <[email protected]> Gerrit-Reviewer: John Vandenberg <[email protected]> Gerrit-Reviewer: Ladsgroup <[email protected]> Gerrit-Reviewer: Merlijn van Deen <[email protected]> Gerrit-Reviewer: Nullzero <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ Pywikibot-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
