jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1197031?usp=email )
Change subject: coverage: Remove fallback codes from coverage
......................................................................
coverage: Remove fallback codes from coverage
Change-Id: I013768579f81ca00e1e30b6111098a03ff715948
---
M tests/oauth_tests.py
M tests/page_tests.py
M tests/pagegenerators_tests.py
M tests/proofreadpage_tests.py
4 files changed, 7 insertions(+), 6 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/oauth_tests.py b/tests/oauth_tests.py
index 3f95cde..20a3fdb 100755
--- a/tests/oauth_tests.py
+++ b/tests/oauth_tests.py
@@ -80,7 +80,7 @@
p = pywikibot.Page(self.site, title)
try:
p.site.editpage(p, appendtext='\n' + ts)
- except EditConflictError as e:
+ except EditConflictError as e: # pragma: no cover
self.assertEqual(e.page, p)
else:
revision_id = p.latest_revision_id
@@ -89,7 +89,7 @@
if revision_id == p.latest_revision_id:
self.assertEndsWith(p.text, ts)
else:
- self.assertIn(ts, t)
+ self.assertIn(ts, t) # pragma: no cover
class TestOauthLoginManager(DefaultSiteTestCase, OAuthSiteTestCase):
diff --git a/tests/page_tests.py b/tests/page_tests.py
index cf7e866..a023de2 100755
--- a/tests/page_tests.py
+++ b/tests/page_tests.py
@@ -1014,6 +1014,7 @@
def testPageGet(self) -> None:
"""Test ``Page.get()`` on different types of pages."""
fail_msg = '{page!r}.get() raised {error!r} unexpectedly!'
+ unexpected_exceptions = IsRedirectPageError, NoPageError, SectionError
site = self.get_site('en')
p1 = pywikibot.Page(site, 'User:Legoktm/R2')
p2 = pywikibot.Page(site, 'User:Legoktm/R1')
@@ -1029,7 +1030,7 @@
try:
p2.get(get_redirect=True)
- except (IsRedirectPageError, NoPageError, SectionError) as e:
+ except unexpected_exceptions as e: # pragma: no cover
self.fail(fail_msg.format(page=p2, error=e))
with self.assertRaisesRegex(NoPageError, NO_PAGE_RE):
@@ -1044,7 +1045,7 @@
page = pywikibot.Page(site, 'Manual:Pywikibot/2.0 #See_also')
try:
page.get()
- except (IsRedirectPageError, NoPageError, SectionError) as e:
+ except unexpected_exceptions as e: # pragma: no cover
self.fail(fail_msg.format(page=page, error=e))
def test_set_redirect_target(self) -> None:
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index f2aa0b4..2cf9661 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1453,7 +1453,7 @@
for page in self._generator_with_tests():
self.assertIsInstance(page, pywikibot.Page)
if not isinstance(page, pywikibot.FilePage):
- with self.assertRaisesRegex(ValueError,
+ with self.assertRaisesRegex(ValueError, # pragma: no cover
'does not have a valid extension'):
pywikibot.FilePage(page)
else:
diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py
index 94b20ec..55c4da0 100755
--- a/tests/proofreadpage_tests.py
+++ b/tests/proofreadpage_tests.py
@@ -500,7 +500,7 @@
"""Test page.ocr(ocr_tool='wmfOCR')."""
try:
text = self.page.ocr(ocr_tool='wmfOCR')
- except Exception as exc:
+ except Exception as exc: # pragma: no cover
self.assertIsInstance(exc, ValueError)
else:
ref_text = self.data['wmfOCR']
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1197031?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I013768579f81ca00e1e30b6111098a03ff715948
Gerrit-Change-Number: 1197031
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
