jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1197032?usp=email )
Change subject: Tests: fix TestIndexPageMappings.test_get_page_and_number tests
......................................................................
Tests: fix TestIndexPageMappings.test_get_page_and_number tests
- remove duplicate error tests
- test get_page and get_number with non-empty lists
Change-Id: I602e31dcb8f52017bc7651bd0034e15ff16e783b
---
M tests/proofreadpage_tests.py
1 file changed, 4 insertions(+), 9 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py
index 55c4da0..cad13bc 100755
--- a/tests/proofreadpage_tests.py
+++ b/tests/proofreadpage_tests.py
@@ -791,11 +791,6 @@
self.assertEqual(index_page.get_page_number_from_label(str(label)),
num_set)
- # Error if label does not exists.
- label, num_set = 'dummy label', []
- with self.assertRaises(KeyError):
- index_page.get_page_number_from_label('dummy label')
-
# Test get_page_from_label.
for label, page_set in data['get_page']:
# Get set of pages from label with label as int or str.
@@ -804,10 +799,6 @@
self.assertEqual(index_page.get_page_from_label(str(label)),
page_set)
- # Error if label does not exists.
- with self.assertRaises(KeyError):
- index_page.get_page_from_label('dummy label')
-
# Test get_page.
for n in num_set:
p = index_page.get_page(n)
@@ -818,6 +809,10 @@
n = index_page.get_number(p)
self.assertEqual(index_page.get_page(n), p)
+ # Error if label does not exists.
+ with self.assertRaises(KeyError):
+ index_page.get_page_number_from_label('dummy label')
+
def test_page_gen(self, key) -> None:
"""Test Index page generator."""
data = self.sites[key]
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1197032?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I602e31dcb8f52017bc7651bd0034e15ff16e783b
Gerrit-Change-Number: 1197032
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
