jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1325934?usp=email )
Change subject: api: Avoid copying request keys for slot checks
......................................................................
api: Avoid copying request keys for slot checks
QueryGenerator built a temporary set of every request key for each
revision module when checking for deprecated parameters.
Compare the request key view directly with each deprecated parameter set.
This preserves the guard while avoiding the temporary key sets.
Change-Id: Ie7aa49b40fdeb29a8ce1525da760e591b86d1ae2
---
M pywikibot/data/api/_generators.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/data/api/_generators.py
b/pywikibot/data/api/_generators.py
index f049802..8a2d2e3 100644
--- a/pywikibot/data/api/_generators.py
+++ b/pywikibot/data/api/_generators.py
@@ -403,14 +403,14 @@
deprecated_params = {
'rvexpandtemplates', 'rvparse', 'rvdiffto', 'rvdifftotext',
'rvdifftotextpst', 'rvcontentformat', 'parsetree'}
- if not set(request) & deprecated_params:
+ if request.keys().isdisjoint(deprecated_params):
request['rvslots'] = '*'
if 'deletedrevisions' in props:
deprecated_params = {
'drvexpandtemplates', 'drvparse', 'drvdiffto',
'drvdifftotext', 'drvdifftotextpst', 'drvcontentformat',
'parsetree'}
- if not set(request) & deprecated_params:
+ if request.keys().isdisjoint(deprecated_params):
request['drvslots'] = '*'
lists = request.get('list')
if lists:
@@ -419,14 +419,14 @@
'arvexpandtemplates', 'arvparse', 'arvdiffto',
'arvdifftotext', 'arvdifftotextpst', 'arvcontentformat',
'parsetree'}
- if not set(request) & deprecated_params:
+ if request.keys().isdisjoint(deprecated_params):
request['arvslots'] = '*'
if 'alldeletedrevisions' in lists:
deprecated_params = {
'adrexpandtemplates', 'adrparse', 'adrdiffto',
'adrdifftotext', 'adrdifftotextpst', 'adrcontentformat',
'parsetree'}
- if not set(request) & deprecated_params:
+ if request.keys().isdisjoint(deprecated_params):
request['adrslots'] = '*'
def set_query_increment(self, value) -> None:
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1325934?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ie7aa49b40fdeb29a8ce1525da760e591b86d1ae2
Gerrit-Change-Number: 1325934
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
