jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1325899?usp=email )
Change subject: wikibase: Reuse sitelink badge sets
......................................................................
wikibase: Reuse sitelink badge sets
Convert old and new badge collections once while building sitelink diffs.
Use mapping key views directly when finding removed sitelinks.
Change-Id: If722d49c1ed744d2695d7cf56b4efb2144ed2a73
---
M pywikibot/page/_collections.py
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page/_collections.py b/pywikibot/page/_collections.py
index 218198b..263cf3a 100644
--- a/pywikibot/page/_collections.py
+++ b/pywikibot/page/_collections.py
@@ -465,18 +465,17 @@
diffto_link = diffto[dbname]
if diffto_link.get('title') == sitelink.get('title'):
# compare badges
- diffto_badges = diffto_link.get('badges', [])
- badges = sitelink.get('badges', [])
- tmp_badges = [''] * len(set(diffto_badges) - set(badges))
- for badge in set(badges) - set(diffto_badges):
- tmp_badges.append(badge)
+ diffto_badges = set(diffto_link.get('badges', []))
+ badges = set(sitelink.get('badges', []))
+ tmp_badges = [''] * len(diffto_badges - badges)
+ tmp_badges.extend(badges - diffto_badges)
if tmp_badges:
data[dbname]['badges'] = tmp_badges
else:
to_nuke.append(dbname)
# find removed sitelinks
- for dbname in (set(diffto.keys()) - set(self.keys())):
+ for dbname in diffto.keys() - self.keys():
badges = [''] * len(diffto[dbname].get('badges', []))
data[dbname] = {'site': dbname, 'title': ''}
if badges:
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1325899?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: If722d49c1ed744d2695d7cf56b4efb2144ed2a73
Gerrit-Change-Number: 1325899
Gerrit-PatchSet: 2
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
