jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1361144?usp=email )
Change subject: api: Remove deprecated Request.iteritems method
......................................................................
api: Remove deprecated Request.iteritems method
Request.iteritems was deprecated in Pywikibot 9 in favour of items()
and is scheduled for removal in Pywikibot 12. Remove the wrapper, its
unused decorator import, and its pending-removal entry from ROADMAP.rst.
Change-Id: Ibf1752c793abf36af87c132920ac3ab528a18e54
---
M ROADMAP.rst
M pywikibot/data/api/_requests.py
2 files changed, 0 insertions(+), 11 deletions(-)
Approvals:
Mahveotm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ROADMAP.rst b/ROADMAP.rst
index f06960a..e76d1d1 100644
--- a/ROADMAP.rst
+++ b/ROADMAP.rst
@@ -55,7 +55,6 @@
* 9.0.0: ``dict`` parameter of :class:`data.api.OptionSet` was renamed to
``data``
* 9.0.0: ``allrevisions`` parameter of :class:`xmlreader.XmlDump` is
deprecated, use ``revisions`` instead
(:phab:`T340804`)
-* 9.0.0: ``iteritems`` method of :class:`data.api.Request` will be removed in
favour of ``items``
Pending removal in Pywikibot 13
diff --git a/pywikibot/data/api/_requests.py b/pywikibot/data/api/_requests.py
index c800e32..452b767 100644
--- a/pywikibot/data/api/_requests.py
+++ b/pywikibot/data/api/_requests.py
@@ -44,7 +44,6 @@
)
from pywikibot.login import LoginStatus
from pywikibot.textlib import removeDisabledParts, removeHTMLParts
-from pywikibot.tools import deprecated
__all__ = ('CachedRequest', 'Request', 'encode_url')
@@ -415,15 +414,6 @@
"""Implement dict interface."""
return len(self._params)
- @deprecated('items()', since='9.0.0')
- def iteritems(self):
- """Implement dict interface.
-
- .. version-deprecated:: 9.0
- Use ``items()`` instead.
- """
- return iter(self.items())
-
def _add_defaults(self) -> None:
"""Add default parameters to the API request.
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1361144?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ibf1752c793abf36af87c132920ac3ab528a18e54
Gerrit-Change-Number: 1361144
Gerrit-PatchSet: 3
Gerrit-Owner: Mahveotm <[email protected]>
Gerrit-Reviewer: Mahveotm <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
