jayvdb added a comment.

Well, ideally neither is 'moved' as such, but -yesterday and -recentchanges are 
replaced with standard pagegenerator arguments where possible to achieve the 
same result, e.g." -uploadlog" and generic pagegenerators / filters are used 
where not possible.

For providing backwards compatibility for '-yesterday' , you can do something 
like

  if arg == '-yesterday':
      gen.handleArg('-uploadlog')

Then you need to restrict the date range of the upload log to 'yesterday'.  To 
restrict the date, add an EdittimeFilterPageGenerator after calling 
getCombinedGenerator.

However currently EdittimeFilterPageGenerator will continue to consume all 
entries outside of the date range(which could take forever); we need an option 
to tell it to stop when it first encounters a date outside of the range.

Replacing the custom -recentchanges might be a bit harder to do, so tackle that 
after you've done -yesterday, or I was planning to create it as another task.  
We could replace it with standard arguments "-recentchanges -ns:6", but the 
delay=120 means the current implementation is not fetching a lot of records 
from the start of the recentchanges log.

(and give it a decent module docstring)


TASK DETAIL
  https://phabricator.wikimedia.org/T67192

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: pywikipedia-bugs, valhallasw, Multichill, Ricordisamoa, jayvdb, 
Liuxinyu970226, Daviskr



_______________________________________________
Pywikipedia-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-bugs

Reply via email to