Given the support and feedback that I have received going back to the horribly broken addition by Trigon of a logging system Filling bugs is useless. Here is a quote from IRC earlier today:
<Me> having the framework check git on every script invoke is assine <valhallasw> No, it's not. <valhallasw> There's basically no other way to get the current checkout version. <Me> I guess you havent heard of caching that information and only checking ever X days? <valhallasw> why would that be a sensible strategy? <valhallasw> because that would add a lot of code for exactly zero gain Per valhallasw's request I did some profiling, They quoted a 0.37 seconds run-time to invoke "interwiki.py -help" I ran the same tests, both with a clean git checkout and my modified checkout. 0.389 seconds (mine) vs 1.257 that is a factor of 3 in regards to execution time (all I really did was remove the version checks on every script invoke) Besides the execution time it adds an additional ~500 hits per day to the git servers for my scheduled tasks. Extrapolate that across the number of operators that we have, and thats no small chunk of change. I also got a nice lecture about toning my temper down, for calling out these rather significant bad ideas. I have kept a very cool head and my temper is a non-issue, I just call a spade a spade. Besides those issues, the decision to make the incomplete and broken "rewrite" into "core" and shelve the easier to use and more stable trunk into "compat" was an issue that wont get resolved. Ive tried several times to get it setup on windows and guess what? it works about as well as a square tire. I spent about 30 seconds and found 6 issues that make the branch unusable on windows. I have lost count of the number of people who have come into irc://freenode/pywikipediabot asking for help setting up core and have been unable. Setting up compat? takes less than 5 instructions and I have yet to have someone unable to do it. On core? Ive had maybe 3 be able to do it. Switching to git wasnt that big of an issue, however the forced use of gerrit is. Gerrit has no usable windows based interface. and then your code gets -2'ed because the reviewer has no clue about the changes being made and instead of asking just gives a comment that shows they are reviewing code that they know zero about. Having to use the gerrit patch uploader to even get things submitted is ugly as I got -2'ed for PEP8 spacing issues that where correct in my code, but between git and the patch uploader somehow got eaten. On Sat, Jan 11, 2014 at 4:57 PM, Tom Morris <[email protected]> wrote: > On Sat, Jan 11, 2014 at 6:52 AM, John <[email protected]> wrote: > >> I will have to agree with Bináris, Ive hacked my local checkout to avoid >> the recent fuckups that have been added. I basically killed the whole >> externals import process and several other things. > > > Presumably you filed bug reports as well, right? Otherwise it's pretty > unlikely things will improve. > > Tom > > _______________________________________________ > Pywikipedia-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l > >
_______________________________________________ Pywikipedia-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
