On 11 January 2014 23:28, John <[email protected]> wrote: > Given the support and feedback that I have received going back to the > horribly broken addition by Trigon of a logging system Filling bugs is > useless. Here is a quote from IRC earlier today: > (...)
> Per valhallasw's request I did some profiling, They quoted a 0.37 seconds > run-time to invoke "interwiki.py -help" I ran the same tests, both with a > clean git checkout and my modified checkout. 0.389 seconds (mine) vs 1.257 > that is a factor of 3 in regards to execution time (all I really did was > remove the version checks on every script invoke) Besides the execution time it adds an additional ~500 hits per day to the > git servers for my scheduled tasks. I still really don't get the issue with a second. Sure, it could be faster. Sure, it could be more efficient. Sure, we could save git.wikimedia.orgsome requests (but I have not had complaints from the WMF, so it's probably not an issue). But I really cannot be bothered spending my time to fix this for you. As I mentioned, you are more than welcome to submit a patch, but maybe not the one which you yourself described as "[a] fix [that] has about as much chance of being accepted as a snowball in hell". I'm not opposed to caching, nor to adding a user-config option to remove version checking. I also got a nice lecture about toning my temper down, for calling out > these rather significant bad ideas. I have kept a very cool head and my > temper is a non-issue, I just call a spade a spade. > I am, however, opposed to calling changes 'obnoxious fuckup's. Besides those issues, the decision to make the incomplete and broken > "rewrite" into "core" and shelve the easier to use and more stable trunk > into "compat" was an issue that wont get resolved. Ive tried several times to get it setup on windows and guess what? it works > about as well as a square tire. I spent about 30 seconds and found 6 issues > that make the branch unusable on windows. As Tom mentioned: have you created bugs for these? Because I have absolutely zero issues with core on windows, and I've been using it without any issues on linux for ages. > I have lost count of the number of people who have come into > irc://freenode/pywikipediabot asking for help setting up core and have > been unable. Setting up compat? takes less than 5 instructions and I have > yet to have someone unable to do it. On core? Ive had maybe 3 be able to do > it. > Well, then core clearly is better, with the one-liner 'pwb.py login'. But seriously, I have no clue what problems you encounter. Download python, download a nightly, run a bot. Nothing has changed in that respect. > and then your code gets -2'ed because the reviewer has no clue about the > changes being made and instead of asking just gives a comment that shows > they are reviewing code that they know zero about. I sincerely doubt that. > Having to use the gerrit patch uploader to even get things submitted is > ugly as I got -2'ed for PEP8 spacing issues that where correct in my code, > but between git and the patch uploader somehow got eaten. > And again, please open a bug report, as this should not happen: https://github.com/valhallasw/gerrit-patch-uploader/issues Merlijn
_______________________________________________ Pywikipedia-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
