On Wed, 13 Apr 2016 21:14:19 +0530 Sinny Kumari <ksi...@gmail.com> wrote:
Thank you for getting this done, I'm excited to start it running in Taskotron. <snip> > You need to decide whether it is better to run libabigain against > every new > > Koji build, or just against every new Bodhi update. From a quick > > look, I think it makes more sense to run libabigail on every new > > Koji build, so that people can see the results even before creating > > the update (that requires looking into ResultsDB manually at the > > moment). If we run it on every Koji build, the results will still > > show up in Bodhi - Bodhi should query ResultsDB and show the > > results for those particular builds present in the update. (We > > might need to teach Bodhi about libabigail existence, I'm not > > sure). Ultimately it's your choice, what makes more sense for your > > check. > > I believe that when we say every new Koji build, we are talking about > non-scratch build which doesn't include scratch build done by anyone. > If my assumption is right, then yes running libabigail task on each > koji build will be good. It is possible to do that with current > implementation since libabigail task look for a koji build-id to > download corresponding rpms. I'd advocate for running libabigail against koji builds, if possible. There are no updates in rawhide and I think it'd be useful to have abi checks running on rawhide builds. <snip> > > We try to have at least some basic documentation and FAQ for our > > checks in there. Currently it's not very discoverable (we should > > link to it at least from ResultsDB, which we currently don't) and > > the location can change, but at least it's a link we can give to > > people when asking basic questions about one of our tasks. Also, > > since you're going to maintain the task and not us, please include > > some "Contact" section where to post feedback or report bugs (e.g. > > github issues page). If people ask us about the task and we don't > > know the answer, we will point them to that wiki page. > > Will add contact section in wiki page. > I wonder if it is better to have this included with other fedora qa > tasks? By "have this included wiht other fedora qa tasks", do you mean have the git repo hosted in the same place? If so, I'd say that's up to you but I expect to be moving all our repos off of bitbucket and into something hosted in Fedora in the next month or so. If you do decide that you want the task hosted that way, I'd suggest waiting until we move all of our current repos so that there's only one change. If I misunderstood, would you rephrase the question? Again, thanks for getting this done. Tim
pgpWMX2pBC9l5.pgp
Description: OpenPGP digital signature
_______________________________________________ qa-devel mailing list qa-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/qa-devel@lists.fedoraproject.org
