On Thu, 03/26 15:32, Wen Congyang wrote:
> On 03/26/2015 03:21 PM, Fam Zheng wrote:
> > On Wed, 03/25 17:36, Wen Congyang wrote:
> >> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
> >> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
> >> Signed-off-by: Gonglei <arei.gong...@huawei.com>
> >> ---
> >> block/nbd.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 49 insertions(+)
> >>
> >> diff --git a/block/nbd.c b/block/nbd.c
> >> index 3faf865..753b322 100644
> >> --- a/block/nbd.c
> >> +++ b/block/nbd.c
> >> @@ -458,6 +458,52 @@ static void nbd_refresh_filename(BlockDriverState *bs)
> >> bs->full_open_options = opts;
> >> }
> >>
> >> +static void nbd_start_replication(BlockDriverState *bs, COLOMode mode,
> >> + Error **errp)
> >> +{
> >> + BDRVNBDState *s = bs->opaque;
> >> +
> >> + /*
> >> + * TODO: support COLO_SECONDARY_MODE if we allow secondary
> >> + * QEMU becoming primary QEMU.
> >> + */
> >> + if (mode != COLO_MODE_PRIMARY) {
> >> + error_set(errp, QERR_INVALID_PARAMETER, "mode");
> >
> > Please use error_setg. (Please grep the whole series :)
>
> Why? QERR_INVALID_PARAMETER includes ERROR_CLASS_GENERIC_ERROR.
Because error classes are deprecated. See also commit 5b347c5410.
Fam
