On 03/26/2015 04:28 AM, Gonglei wrote: >>>> Grammar review only (I'll leave the technical review to others) >>>>
>>>>>> +Copyright Fujitsu, Corp. 2015 >>>>>> +Copyright (c) 2015 Intel Corporation >>>>>> +Copyright (c) 2015 HUAWEI TECHNOLOGIES CO.,LTD. >>>> >>>> Space after comma in English writing. >> Yes, but I am not sure I can change it. HUAWEI always use this way. Copyright lines are one thing that I am reluctant to change if it is not my own line (some companies have policies on how their lines must look, and I'm not in a position to argue the policy as I am not a lawyer). >> You can find it in bootdevice.c Such existing precedence is a strong argument to NOT changing it, at least for a patch author that is not the copyright owner. > > Good catch, Eric is right. I will change all of this writing way in Qemu at > 2.4. So, sounds like such a change would be a separate patch (probably through the -trivial tree), and cover all files in the repo in one go, without affecting this series. Such a patch by a copyright owner would have no problem being accepted, if it is wanted. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
