On 09/18/2015 07:16 AM, Alberto Garcia wrote: > This fixes the problem detect by Fam: the previous series was deleting > the 'backing' option for 'blockdev-add' even if it contained a > non-empty string. > > The code is also rebased on top of the current master. In particular > the test output had to be adapted because of fe646693. > > Again, this depends on Max's BlockBackend and media series: > > https://lists.gnu.org/archive/html/qemu-block/2015-07/msg00382.html > > Berto > > v5: > - Don't delete the 'backing' option if it contains something different > from an empty string. > - Rebase on top of the current master.
Oops, I added some review comments on v4 before seeing that you had already posted v5. I have some potential naming changes to 3/4 that should be considered (namely, s/snapshot/overlay/ for the name of the node that is being added to the chain); and which may necessitate a v6. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
