On Mon, Feb 03, 2025 at 01:25:29PM -0500, Stefan Hajnoczi wrote:
> BLOCK_OP_TYPE_DATAPLANE prevents BlockDriverState from being used by
> virtio-blk/virtio-scsi with IOThread. Commit b112a65c52aa ("block:
> declare blockjobs and dataplane friends!") eliminated the main reason
> for this blocker in 2014.Wow, that's a long time. > > Nowadays the block layer supports I/O from multiple AioContexts, so > there is even less reason to block IOThread users. Any legitimate > reasons related to interference would probably also apply to > non-IOThread users. > > The only remaining users are bdrv_op_unblock(BLOCK_OP_TYPE_DATAPLANE) > calls after bdrv_op_block_all(). If we remove BLOCK_OP_TYPE_DATAPLANE > their behavior doesn't change. > > Existing bdrv_op_block_all() callers that don't explicitly unblock > BLOCK_OP_TYPE_DATAPLANE seem to do so simply because no one bothered to > rather than because it is necessary to keep BLOCK_OP_TYPE_DATAPLANE > blocked. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > include/block/block-common.h | 1 - > block/replication.c | 1 - > blockjob.c | 2 -- > hw/block/virtio-blk.c | 9 --------- > hw/scsi/virtio-scsi.c | 3 --- > 5 files changed, 16 deletions(-) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
