On 05/18/2016 06:27 AM, Kevin Wolf wrote: > This covers some more write_zeroes cases which are relevant for the > recent qcow2 optimisations that check the allocation status of the > backing file for partial cluster write_zeroes requests. > > This needs to be separate from 034 because we can only support qcow2 in > this test case for multiple reasons: We check the allocation status > after write_zeroes with 'qemu-img map' and the optimised behaviour that > produces zero clusters is only implemented in qcow2; second, the map > command returns offsets that are qcow2 specific; and finally, we also > use 512 byte clusters which aren't supported for formats like qed. > > Signed-off-by: Kevin Wolf <[email protected]> > --- > > v2: > - Some more test cases, including one suggested by Eric > - Comments in the test script that visualise each case with ASCII art
Nice! > +# qcow2 specific bdrv_write_zeroes tests with backing files (complements 034) Maybe also worth a one line tweak to 034 to give a comment pointing to this file (so the two mutually reference each other), but that doesn't require a respin. Reviewed-by: Eric Blake <[email protected]> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
