On Tue, Sep 23, 2025 at 02:30:01PM +0800, Ray Lee wrote:
> Signed-off-by: Ray Lee <hburay...@gmail.com>
> ---
>  block/mirror.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

This patch does what it says, but lacks a rationale as to why it is
important.  What was confusing about the existing name?  Is this
intended to be part of a larger series where some other patch will be
easier to read with the difference in naming?  Is it because of
collisions between static functions in two different .o files making
gdb breakpoints harder to understand?  Or something else altogether?

Since the commit message didn't list a reason why this patch would
matter, I'm inclined to treat it as churn for the sake of churn, not
fixing any bugs.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org


Reply via email to