On Fri, Oct 10, 2025 at 01:55:28PM +0200, Thomas Huth wrote: > On 08/10/2025 13.35, Daniel P. Berrangé wrote: > > CI is only exercising the qcow2 'auto' tests currently. As a result we > > get no exposure of changes which cause regressions in other block format > > drivers. > > > > This adds new CI jobs for each block format, that will run the target > > 'make check-block-$FORMAT'. The jobs are separate so that we have the > > ability to make each formats gating or not, depending on their level > > of reliability. > > Some of the jobs seem to be quite quick, though, only 5 minutes and less: > > https://gitlab.com/berrange/qemu/-/jobs/11633680698 > https://gitlab.com/berrange/qemu/-/jobs/11633680704 > https://gitlab.com/berrange/qemu/-/jobs/11633680694 > > I think I'd prefer to see them rather merged into one job, to avoid that we > waste too much time with setting up the container each time. We can still > sort out flaky parts into separate jobs later if necessary.
The container setup / job prep is not a significant time sink - just at the 1 minute mark. I wanted to have separate jobs per backend so that the pipeline dashboard gives an informative summary of which block backends are impacted by the change, rather than having to search the logs to discover it. Flaky parts shouldn't be separate jobs - the tests should either be fixed or removed, because unreliable tests just end up being ignored, leading to regressions being missed. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
