On Fri, Jan 30, 2026 at 06:37:11PM -0700, Keith Busch wrote: > On Wed, Jan 28, 2026 at 10:23:11AM -0800, Klaus Jensen wrote: > > On Jan 25 17:56, Philippe Mathieu-Daudé wrote: > > > On 25/1/26 07:42, Akihiko Odaki wrote: > > > > The bootindex suffix can be used as long as the property is alive. > > > > > > True, so: > > > > > > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > > > > > > But maybe it shouldn't (we should g_strdup it like other QOM fields). > > > > > > > Do you mean that device_add_bootindex_property() should g_strdup the > > suffix? And then free it in property_release_bootindex()? That would > > make sense to me. > > Doesn't it already do that? > > device_add_bootindex_property > object_property_add > object_property_try_add > g_strdup > > ?
Sorry, nevermind. I was tracking the "name", not the "suffix", in which case I agree with Klaus. If only for consistency between the two "const char *" parameters.
