On 06/13/2016 06:04 AM, Paolo Bonzini wrote: > > > On 12/05/2016 00:39, Eric Blake wrote: >> Clean up some debug message oddities missed earlier; this includes >> some typos, and recognizing that %d is not necessarily compatible >> with uint32_t. > > Actually it should be on any POSIX platform, since (by way of the > requirements on limits.h) POSIX requires sizeof(int) to be >= 4.
Not quite true. On 32-bit platforms, uint32_t can be 'long' rather than 'int' (I think 32-bit cygwin used to be in this camp, once - I don't remember if it is still the case). Thus, PRId32 is NOT necessarily "d" on all platforms. > > I will apply the patch, but fully expect this to bitrot... > > Paolo > >> Also add a couple messages that I found useful >> while debugging things. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
