On 05/03/2016 09:23 AM, Kevin Wolf wrote: > Am 06.04.2016 um 20:28 hat Max Reitz geschrieben: >> Turns out NBD is not so simple to do if you do it right. Anyway, this >> series adds blockdev-add support for NBD clients. > > What the series does seems to make sense to me, though things would be a > bit nicer (especially on the command line) if SocketAddress had been a > flat union from the beginning. It's too late to change now, and I guess > the ugliness isn't worth duplicating it.
I'm sorely tempted to make SocketAddress a flat union anyways (or even an alternate that can be flat or nested at will), if only for convenience. But that's a pipe dream - there's probably not enough time before 2.7 to actually achieve it. > > I'll leave the in-detail review to our NBD folks. > > Kevin > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
