On 07/04/2016 06:28 AM, Denis V. Lunev wrote: > From: Pavel Butsykin <[email protected]> > > Now that we can support boxed commands, use it to greatly reduce the > number of parameters (and likelihood of getting out of sync) when > adjusting blockdev-backup parameters. > > Signed-off-by: Pavel Butsykin <[email protected]> > Signed-off-by: Denis V. Lunev <[email protected]> > CC: Jeff Cody <[email protected]> > CC: Markus Armbruster <[email protected]> > CC: Eric Blake <[email protected]> > CC: John Snow <[email protected]> > CC: Stefan Hajnoczi <[email protected]> > CC: Kevin Wolf <[email protected]> > --- > blockdev.c | 65 > +++++++++++++++------------------------------------- > qapi/block-core.json | 6 ++++- > 2 files changed, 24 insertions(+), 47 deletions(-) >
> +++ b/qapi/block-core.json
> @@ -1088,9 +1088,13 @@
> #
> # For the arguments, see the documentation of BlockdevBackup.
> #
> +# Returns: nothing on success
> +# If @device is not a valid block device, DeviceNotFound
> +#
> # Since 2.3
> ##
> -{ 'command': 'blockdev-backup', 'data': 'BlockdevBackup' }
> +{ 'command': 'blockdev-backup', 'box': true,
> + 'data': 'BlockdevBackup' }
Will need a trivial rebase; my pending qapi v9 patches renamed the new
parameter 'boxed' instead of 'box'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
