Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Subject: [Qemu-devel] [PATCH 00/54] New op blocker system, part 1 Message-id: [email protected] === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] - [tag update] patchew/[email protected] -> patchew/[email protected] - [tag update] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 6250670 block: Add Error parameter to bdrv_append() 81ad909 block: Add Error parameter to bdrv_set_backing_hd() 7279c72 block: Assertions for resize permission 75eb5f4 block: Assertions for write permissions eb72651 block: Pass BdrvChild to bdrv_aligned_preadv/pwritev 5ed6aa6 tests: Remove FIXME comments decb6e0 nbd/server: Use real permissions for NBD exports ca8c8f5 migration/block: Use real permissions 50e1e34 hmp: Request permissions in qemu-io a839e2e commit: Add filter-node-name to block-commit 66a7bce mirror: Add filter-node-name to blockdev-mirror 202f494 stream: Use real permissions in streaming block job 25bd3cd mirror: Use real permissions in mirror/active commit block job 51ac8c3 block: Allow backing file links in change_parent_backing_link() 23f65d8 block: BdrvChildRole.attach/detach() callbacks 4e76bef block: Fix pending requests check in bdrv_append() c7b4ae6 backup: Use real permissions in backup block job 4ba5d90 commit: Use real permissions for HMP 'commit' c096907 commit: Use real permissions in commit block job 2fba186 blockjob: Add permissions to block_job_add_bdrv() d07ff30 block: Add BdrvChildRole.stay_at_node ce4d7a7 block: Include details on permission errors in message 12ffb27 block: Add BdrvChildRole.get_parent_desc() c2ce609 blockjob: Add permissions to block_job_create() 62d3e5e hw/block: Introduce share-rw qdev property ce2b431 hw/block: Request permissions 960aefe block: Allow error return in BlockDevOps.change_media_cb() b8f2ec6 block: Request real permissions in blk_new_open() 1a14589 block: Add BDRV_O_RESIZE for blk_new_open() 099cca9 block: Add error parameter to blk_insert_bs() 6b7f8a8 block: Add permissions to blk_new() 3fab508 block: Add permissions to BlockBackend 9dc8540 block: Request real permissions in bdrv_attach_child() 36ab94b block: Require .bdrv_child_perm() with child nodes f38b810 vvfat: Implement .bdrv_child_perm() 71e6c39 block: Request child permissions in format drivers 743f766 block: Default .bdrv_child_perm() for format drivers 2b0de16 block: Request child permissions in filter drivers a360de8 block: Default .bdrv_child_perm() for filter drivers cf4c576 block: Involve block drivers in permission granting 6105af3 block: Let callers request permissions when attaching a child node edfea57 block: Add Error argument to bdrv_attach_child() 74330bd block: Add op blocker permission constants daee2fb tests: Use opened block node for block job tests a81f5d6 vvfat: Use opened node as backing file 64be2da block: Add bdrv_new_open_driver() 8e74a4f block: Factor out bdrv_open_driver() 7da4b8f block: Use BlockBackend for image probing 210ae8d block: Factor out bdrv_open_child_bs() 856867b block: Attach bs->file only during .bdrv_open() d5f1724 block: Pass BdrvChild to bdrv_truncate() 8a0dd79 mirror: Resize active commit base in mirror_run() a2f0a85 qcow2: Use BB for resizing in qcow2_amend_options() 0dcd9f3 blockdev: Use BlockBackend to resize in qmp_block_resize() === OUTPUT BEGIN === Checking PATCH 1/54: blockdev: Use BlockBackend to resize in qmp_block_resize()... Checking PATCH 2/54: qcow2: Use BB for resizing in qcow2_amend_options()... Checking PATCH 3/54: mirror: Resize active commit base in mirror_run()... Checking PATCH 4/54: block: Pass BdrvChild to bdrv_truncate()... Checking PATCH 5/54: block: Attach bs->file only during .bdrv_open()... Checking PATCH 6/54: block: Factor out bdrv_open_child_bs()... ERROR: "foo* bar" should be "foo *bar" #41: FILE: block.c:1551: + BlockDriverState* parent, const BdrvChildRole *child_role, ERROR: "foo* bar" should be "foo *bar" #78: FILE: block.c:1602: + BlockDriverState* parent, total: 2 errors, 0 warnings, 76 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 7/54: block: Use BlockBackend for image probing... Checking PATCH 8/54: block: Factor out bdrv_open_driver()... Checking PATCH 9/54: block: Add bdrv_new_open_driver()... Checking PATCH 10/54: vvfat: Use opened node as backing file... ERROR: "(foo*)" should be "(foo *)" #32: FILE: block/vvfat.c:2971: + .instance_size = sizeof(void*), ERROR: "(foo**)" should be "(foo **)" #43: FILE: block/vvfat.c:3042: + *(void**) backing->opaque = s; total: 2 errors, 0 warnings, 25 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 11/54: tests: Use opened block node for block job tests... Checking PATCH 12/54: block: Add op blocker permission constants... Checking PATCH 13/54: block: Add Error argument to bdrv_attach_child()... Checking PATCH 14/54: block: Let callers request permissions when attaching a child node... Checking PATCH 15/54: block: Involve block drivers in permission granting... Checking PATCH 16/54: block: Default .bdrv_child_perm() for filter drivers... Checking PATCH 17/54: block: Request child permissions in filter drivers... Checking PATCH 18/54: block: Default .bdrv_child_perm() for format drivers... Checking PATCH 19/54: block: Request child permissions in format drivers... Checking PATCH 20/54: vvfat: Implement .bdrv_child_perm()... Checking PATCH 21/54: block: Require .bdrv_child_perm() with child nodes... Checking PATCH 22/54: block: Request real permissions in bdrv_attach_child()... Checking PATCH 23/54: block: Add permissions to BlockBackend... Checking PATCH 24/54: block: Add permissions to blk_new()... Checking PATCH 25/54: block: Add error parameter to blk_insert_bs()... Checking PATCH 26/54: block: Add BDRV_O_RESIZE for blk_new_open()... WARNING: line over 80 characters #155: FILE: include/block/block.h:85: +#define BDRV_O_RESIZE 0x0004 /* requests permission for resizing the node */ total: 0 errors, 1 warnings, 96 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 27/54: block: Request real permissions in blk_new_open()... Checking PATCH 28/54: block: Allow error return in BlockDevOps.change_media_cb()... Checking PATCH 29/54: hw/block: Request permissions... Checking PATCH 30/54: hw/block: Introduce share-rw qdev property... WARNING: line over 80 characters #56: FILE: include/hw/block/block.h:57: + DEFINE_PROP_ON_OFF_AUTO("write-cache", _state, _conf.wce, ON_OFF_AUTO_AUTO), \ total: 0 errors, 1 warnings, 403 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 31/54: blockjob: Add permissions to block_job_create()... Checking PATCH 32/54: block: Add BdrvChildRole.get_parent_desc()... Checking PATCH 33/54: block: Include details on permission errors in message... Checking PATCH 34/54: block: Add BdrvChildRole.stay_at_node... Checking PATCH 35/54: blockjob: Add permissions to block_job_add_bdrv()... Checking PATCH 36/54: commit: Use real permissions in commit block job... Checking PATCH 37/54: commit: Use real permissions for HMP 'commit'... Checking PATCH 38/54: backup: Use real permissions in backup block job... Checking PATCH 39/54: block: Fix pending requests check in bdrv_append()... Checking PATCH 40/54: block: BdrvChildRole.attach/detach() callbacks... Checking PATCH 41/54: block: Allow backing file links in change_parent_backing_link()... Checking PATCH 42/54: mirror: Use real permissions in mirror/active commit block job... WARNING: line over 80 characters #277: FILE: block/mirror.c:1152: + /* XXX BLK_PERM_WRITE needs to be allowed so we don't block ourselves WARNING: line over 80 characters #278: FILE: block/mirror.c:1153: + * at s->base. The other options would be a second filter driver above total: 0 errors, 2 warnings, 313 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 43/54: stream: Use real permissions in streaming block job... Checking PATCH 44/54: mirror: Add filter-node-name to blockdev-mirror... Checking PATCH 45/54: commit: Add filter-node-name to block-commit... Checking PATCH 46/54: hmp: Request permissions in qemu-io... Checking PATCH 47/54: migration/block: Use real permissions... Checking PATCH 48/54: nbd/server: Use real permissions for NBD exports... Checking PATCH 49/54: tests: Remove FIXME comments... Checking PATCH 50/54: block: Pass BdrvChild to bdrv_aligned_preadv/pwritev... Checking PATCH 51/54: block: Assertions for write permissions... Checking PATCH 52/54: block: Assertions for resize permission... Checking PATCH 53/54: block: Add Error parameter to bdrv_set_backing_hd()... Checking PATCH 54/54: block: Add Error parameter to bdrv_append()... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
