On 21.02.2017 15:58, Kevin Wolf wrote: > Management tools need to be able to know about every node in the graph > and need a way to address them. This new option to blockdev-mirror > allows the client to set a node-name for the automatically inserted > filter driver, and at the same time serves as a witness that this > version of qemu does automatically insert a filter driver. > > Signed-off-by: Kevin Wolf <[email protected]> > --- > block/mirror.c | 14 ++++++++------ > blockdev.c | 12 +++++++++++- > include/block/block_int.h | 5 ++++- > qapi/block-core.json | 8 +++++++- > 4 files changed, 30 insertions(+), 9 deletions(-)
Reviewed-by: Max Reitz <[email protected]> I'm not so happy about "...serves as a witness..." because that doesn't make it less of an incompatible change. However, since (as you know) I had plans to introduce such a filter node myself anyway, I'll gladly let you take all the git-blame if something breaks. (And it should be easy for me to add the mirror target as another child to the filter node.) Max
signature.asc
Description: OpenPGP digital signature
