On 06/05/2017 08:55 AM, Peter Maydell wrote: > Coverity points out that the code path in qcow_create() for > the magic "fat:" backing file name leaks the memory used to > store the filename (CID 1307771). Free the memory before > we overwrite the pointer. > > Signed-off-by: Peter Maydell <[email protected]> > --- > block/qcow.c | 1 + > 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <[email protected]> > > diff --git a/block/qcow.c b/block/qcow.c > index 95ab123..7bd94dc 100644 > --- a/block/qcow.c > +++ b/block/qcow.c > @@ -852,6 +852,7 @@ static int qcow_create(const char *filename, QemuOpts > *opts, Error **errp) > header_size += backing_filename_len; > } else { > /* special backing file for vvfat */ > + g_free(backing_file); > backing_file = NULL; > } > header.cluster_bits = 9; /* 512 byte cluster to avoid copying > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
