On 07/12/2017 04:00 PM, John Snow wrote: > > > On 07/03/2017 11:10 AM, Eric Blake wrote: >> Now that all callers are using byte-based interfaces, there's no >> reason for our internal hbitmap to remain with sector-based >> granularity. It also simplifies our internal scaling, since we >> already know that hbitmap widens requests out to granularity >> boundaries. >> >> Signed-off-by: Eric Blake <[email protected]> >>
>> @@ -310,7 +305,6 @@ void bdrv_dirty_bitmap_truncate(BlockDriverState *bs) >> int64_t size = bdrv_getlength(bs); >> >> assert(size >= 0); >> - size = DIV_ROUND_UP(size, BDRV_SECTOR_SIZE); > > whoops uh, were we setting bitmap->size to the *sector* size prior to > this, even though we had already changed bitmap->size to be the byte size? Oops. Looks like I have a bug in my rebasing of 5/17. Good catch; I'll have to post v5. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
