On 07/13/2017 04:16 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.07.2017 18:10, Eric Blake wrote: >> Now that we have adjusted the majority of the calls this function >> makes to be byte-based, it is easier to read the code if it makes >> passes over the image using bytes rather than sectors. >> >> Signed-off-by: Eric Blake <[email protected]> >> >> --- >> v4: new patch >> ---
>>
>> - if (offset == 0) {
>> + if (data_offset == 0) {
>> if (entry & BME_TABLE_ENTRY_FLAG_ALL_ONES) {
>> - bdrv_dirty_bitmap_deserialize_ones(bitmap,
>> - sector *
>> BDRV_SECTOR_SIZE,
>> - count *
>> BDRV_SECTOR_SIZE,
>> + bdrv_dirty_bitmap_deserialize_ones(bitmap, offset,
>> count,
>
> The change is that now 3rd parameter may not be aligned by sectors, but
> looks like it should be ok.
Correct - the dirty bitmap automatically widens any non-aligned input
into granularity.
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy<[email protected]>
>
I posted a v5 prior to this email, if you want to add your Reviewed-by
on any patches there (I think this patch went unchanged into that
revision, but scripts don't always pick up R-b given on a previous
version of a patch).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
