On 09/05/2017 08:10 AM, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> We already have another qtest_init() in the tree, for the >> top-level qtest.c device; having two functions with different >> signatures is confusing. Rename the libqtest version to >> qtest_start() to eliminate the duplication. > > This is too much code churn for my taste, and I also do not like the > idea of naming the function qtest_start() - since this was a function > with different semantics before your patch 28/29, so this will cause > confusion for all the people who are used to the old qtest_start() > function or who want to backport patches that have done after this > change to a code level before this change. > > If you are really bugged by the qtest_init() name clash, I think it's > way easier if you rename the qtest_init() in the qtest.c file instead.
Except the qtest_init() in qtest.c really is our normal pattern of *_init for devices, so that one's named correctly. Our testsuite is the one that is using a name different from its normal usage in the rest of the tree. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature