On 01/05/2018 08:44 AM, Murilo Opsfelder Araujo wrote:
> This patch prevents a possible segmentation fault when .desc members are
> checked
> against NULL.
>
> The ssh_runtime_opts was added by commit
> 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("block/ssh: Use QemuOpts for runtime
> options").
>
> This fix was inspired by
> http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00883.html.
>
> Fixes: 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("block/ssh: Use QemuOpts for
> runtime options")present since 2.7.0, so we've gotten lucky that no one has actually encountered a crash (but I didn't try hard to see if one was possible) > Cc: Max Reitz <[email protected]> > Cc: Eric Blake <[email protected]> > Signed-off-by: Murilo Opsfelder Araujo <[email protected]> > --- > block/ssh.c | 1 + > 1 file changed, 1 insertion(+) CC: [email protected] Reviewed-by: Eric Blake <[email protected]> > > diff --git a/block/ssh.c b/block/ssh.c > index b049a16eb9..8890a0c4ba 100644 > --- a/block/ssh.c > +++ b/block/ssh.c > @@ -556,6 +556,7 @@ static QemuOptsList ssh_runtime_opts = { > .type = QEMU_OPT_STRING, > .help = "Defines how and what to check the host key against", > }, > + { /* end of list */ } > }, > }; > > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
