On 11/22/2017 04:02 PM, Eric Blake wrote: > On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> >> --- >> nbd/server.c | 40 +++++++++++++--------------------------- >> 1 file changed, 13 insertions(+), 27 deletions(-) >> > > Nice diffstat; shows that this one probably makes sense (even if it will > need rebasing on top of the planned churn for the rest of the series). > >> diff --git a/nbd/server.c b/nbd/server.c >> index 79b937d88f..975fe8efe9 100644 >> --- a/nbd/server.c >> +++ b/nbd/server.c >> @@ -152,43 +152,29 @@ static inline int nbd_opt_drop(NBDClient *client, >> size_t size, Error **errp) >> return nbd_drop(client->ioc, size, errp); >> } >> >> +static inline void set_be_option_rep(NBDOptionReply *rep, uint32_t option, >> + uint32_t type, uint32_t length) > > 'static inline' is probably pointless; the compiler already knows what > static functions are ideal to inline, without us having to name it (I > realize you've already done this in other patches, so I probably ought > to post a cleanup patch that removes 'inline').
Then again, we're using it in other .c files, so there's nothing particularly wrong in keeping it as is. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature