On 12/15/2017 06:53 AM, Alberto Garcia wrote: > qcow2_update_snapshot_refcount() increases the refcount of all > clusters of a given snapshot. In order to do that it needs to load all > its L2 tables and iterate over their entries. Since we'll be loading > L2 slices instead of full tables we need to add an extra loop that > iterates over all slices of each L2 table. > > This function doesn't need any additional changes so apart from that > this patch simply updates the variable name from l2_table to l2_slice. > > Signed-off-by: Alberto Garcia <[email protected]> > --- > block/qcow2-refcount.c | 150 > ++++++++++++++++++++++++++----------------------- > 1 file changed, 80 insertions(+), 70 deletions(-) >
> - l2_table = NULL; > + l2_slice = NULL; > l1_table = NULL; > l1_size2 = l1_size * sizeof(uint64_t); > > + slice_size = s->l2_slice_size * sizeof(uint64_t); Again, better naming on s->l2_slice_size in an earlier patch may make this more readable, at a cost of slight rebase churn. The diff looks hideous, but that's thanks to indentation changes. Reviewed-by: Eric Blake <[email protected]> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
