On 05/31/2018 07:28 PM, John Snow wrote: > This set just adds register names so that the read/write traces make > more sense on their own without having to memorize register offsets. > It also splits read/write traces into supported/unsupported subsets, > so you can just monitor for things that QEMU is likely doing wrong. > > v2: > - Added qemu_log_mask(LOG_UNIMP, ...) statements in addition to traces > for writes to unknown/unsupported registers. (Philippe)
Thanks, With format string and style issues reported by checkpatch fixed: Reviewed-by: Philippe Mathieu-Daudé <[email protected]> (I recommend you to setup the scripts/git.orderfile to ease reviews). > > John Snow (16): > ahci: add port register enumeration > ahci: modify ahci_port_read to use register numbers > ahci: make port read traces more descriptive > ahci: fix spacing damage on ahci_port_write > ahci: combine identical clauses in port write > ahci: modify ahci_port_write to use register numbers > ahci: make port write traces more descriptive > ahci: delete old port register address definitions > ahci: add host register enumeration > ahci: fix host register max address > ahci: modify ahci_mem_read_32 to work on register numbers > ahci: make mem_read_32 traces more descriptive > ahci: fix spacing damage on ahci_mem_write > ahci: adjust ahci_mem_write to work on registers > ahci: delete old host register address definitions > ahci: make ahci_mem_write traces more descriptive > > hw/ide/ahci.c | 314 > ++++++++++++++++++++++++++++++------------------- > hw/ide/ahci_internal.h | 63 ++++++---- > hw/ide/trace-events | 13 +- > 3 files changed, 241 insertions(+), 149 deletions(-) >
