On 05/31/2018 06:49 PM, [email protected] wrote:
> Hi,
>
> This series failed docker-mingw@fedora build test. Please find the testing
> commands and
> their output below. If you have Docker installed, you can probably reproduce
> it
> locally.
>
[ blah blah blah ]
> In file included from /tmp/qemu-test/src/hw/ide/ahci.c:30:0:
> /tmp/qemu-test/src/hw/ide/ahci.c: In function 'ahci_mem_write':
> /tmp/qemu-test/src/hw/ide/ahci.c:497:38: error: format '%lx' expects argument
> of type 'long unsigned int', but argument 3 has type 'hwaddr {aka long long
> unsigned int}' [-Werror=format=]
> qemu_log_mask(LOG_UNIMP, "Attempted write to unimplemented
> register:"
> ^
> /tmp/qemu-test/src/include/qemu/log.h:85:22: note: in definition of macro
> 'qemu_log_mask'
> qemu_log(FMT, ## __VA_ARGS__); \
> ^~~
> /tmp/qemu-test/src/hw/ide/ahci.c:498:63: note: format string is defined here
> " AHCI host register %s, offset 0x%lx: 0x%"PRIu64,
> ~~^
> %llx
> In file included from /tmp/qemu-test/src/hw/ide/ahci.c:30:0:
> /tmp/qemu-test/src/hw/ide/ahci.c:511:34: error: format '%lx' expects argument
> of type 'long unsigned int', but argument 2 has type 'hwaddr {aka long long
> unsigned int}' [-Werror=format=]
> qemu_log_mask(LOG_UNIMP, "Attempted write to unimplemented register:
> "
> ^
> /tmp/qemu-test/src/include/qemu/log.h:85:22: note: in definition of macro
> 'qemu_log_mask'
> qemu_log(FMT, ## __VA_ARGS__); \
> ^~~
> /tmp/qemu-test/src/hw/ide/ahci.c:512:59: note: format string is defined here
> "AHCI global register at offset 0x%lx: 0x%"PRIu64,
> ~~^
> %llx
Rookie stuff; I forgot hwaddr was just uint64_t, which is implemented as
long on x86_64. Replaced address and value specifications both with
"0x%"PRIx64 in both cases.
--js
