On Wed, 28 Nov 2018, Paul Durrant wrote: > > -----Original Message----- > > From: Kevin Wolf [mailto:[email protected]] > > Sent: 28 November 2018 16:19 > > To: Paul Durrant <[email protected]> > > Cc: [email protected]; [email protected]; xen- > > [email protected]; Stefano Stabellini <[email protected]>; > > Eduardo Habkost <[email protected]>; Michael S. Tsirkin > > <[email protected]>; Marcel Apfelbaum <[email protected]>; Anthony > > Perard <[email protected]>; Paolo Bonzini <[email protected]>; > > Richard Henderson <[email protected]> > > Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and > > 'XenDevice' object hierarchy > > > > Am 21.11.2018 um 16:11 hat Paul Durrant geschrieben: > > > This patch adds the basic boilerplate for a 'XenBus' object that will > > act > > > as a parent to 'XenDevice' PV backends. > > > A new 'XenBridge' object is also added to connect XenBus to the system > > bus. > > > > > > The XenBus object is instantiated by a new xen_bus_init() function > > called > > > from the same sites as the legacy xen_be_init() function. > > > > > > Subsequent patches will flesh-out the functionality of these objects. > > > > > > Signed-off-by: Paul Durrant <[email protected]> > > > > > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c > > > new file mode 100644 > > > index 0000000000..dede2d914a > > > --- /dev/null > > > +++ b/hw/xen/xen-bus.c > > > @@ -0,0 +1,125 @@ > > > +/* > > > + * Copyright (c) Citrix Systems Inc. > > > + * All rights reserved. > > > + */ > > > > This doesn't look very compatible with the GPL. In fact it might even > > make it illegal for the QEMU project to distribute this code. :-) > > > > Other files you add throughout the series seem to have the same problem. > > > > I was working on the assumption that a lack of explicit license meant that > the overall project license as described in item 2 in LICENSE. Did I > misinterpret that text?
It's "All rights reserved." the problem
