> -----Original Message-----
> From: Anthony PERARD [mailto:[email protected]]
> Sent: 28 November 2018 17:10
> To: Paul Durrant <[email protected]>
> Cc: [email protected]; [email protected]; xen-
> [email protected]; Stefano Stabellini <[email protected]>;
> Michael S. Tsirkin <[email protected]>; Marcel Apfelbaum
> <[email protected]>; Paolo Bonzini <[email protected]>; Richard
> Henderson <[email protected]>; Eduardo Habkost <[email protected]>
> Subject: Re: [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice'
> object hierarchy
>
> On Wed, Nov 21, 2018 at 03:11:55PM +0000, Paul Durrant wrote:
> > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
> > new file mode 100644
> > index 0000000000..dede2d914a
> > --- /dev/null
> > +++ b/hw/xen/xen-bus.c
> > @@ -0,0 +1,125 @@
> > +/*
> > + * Copyright (c) Citrix Systems Inc.
> > + * All rights reserved.
>
> You probably should include:
> This work is licensed under the terms of the GNU GPL, version 2 or
> later.
> See the COPYING file in the top-level directory.
>
> As this seems to be a boilerplate used in recent new files, there are
> other similair boilerplates.
>
> Also, I think the copyright line should include a year.
Ok.
>
> > +void xen_bus_init(void)
> > +{
> > + DeviceState *dev = qdev_create(NULL, TYPE_XEN_BRIDGE);
> > +
> > + qbus_create(TYPE_XEN_BUS, dev, NULL);
> > + qdev_init_nofail(dev);
>
> Will we need a hotplug handler for this bus, like it is done with
> TYPE_XENSYSBUS?
I didn't seem to need one even doing 'xl block-attach' after the VM had booted.
I'm really not sure what that does.
Paul
>
>
> The rest looks good,
> Thanks,
>
> --
> Anthony PERARD
