On 1/15/19 9:35 AM, Vladimir Sementsov-Ogievskiy wrote: > 12.01.2019 20:58, Eric Blake wrote: >> Another refactoring creating nbd_negotiate_finish_oldstyle() >> for further reuse during 'qemu-nbd --list'. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> Message-Id: <20181215135324.152629-18-ebl...@redhat.com> >> Reviewed-by: Richard W.M. Jones <rjo...@redhat.com> > > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > > Hmm, looking at this, I found that nbd_start_negotiate() has very unusual > semantics > for @zeroes field, without any comment about it: > > It must be set to true before calling, and nbd_start_negotiate may set it to > true. > > I think better is not to rely on caller initialization and set zeroes to true > at the > beginning of nbd_start_negotiate().
Makes sense; done in my local tree. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
