Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: [email protected] Subject: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' e159d1ed0d docs/interop/firmware.json: Prefer -machine to if=pflash 7b348eb438 pc: Support firmware configuration with -blockdev 2781f626cf pc_sysfw: Pass PCMachineState to pc_system_firmware_init() 5ed81089c8 pc_sysfw: Remove unused PcSysFwDevice 06dfc824b9 pflash_cfi01: Add pflash_cfi01_get_blk() helper ac5ff6df76 vl: Create block backends before setting machine properties 4fd41657da vl: Factor configure_blockdev() out of main() 8e6aa0c7e8 vl: Improve legibility of BlockdevOptions queue 54f785aef6 sysbus: Fix latent bug with onboard devices a74b064b72 vl: Fix latent bug with -global and onboard devices 004bf6fd7a qom: Move compat_props machinery from qdev to QOM 5f4c93ede2 qdev: Fix latent bug with compat_props and onboard devices === OUTPUT BEGIN === 1/12 Checking commit 5f4c93ede2e9 (qdev: Fix latent bug with compat_props and onboard devices) 2/12 Checking commit 004bf6fd7af8 (qom: Move compat_props machinery from qdev to QOM) 3/12 Checking commit a74b064b72d7 (vl: Fix latent bug with -global and onboard devices) 4/12 Checking commit 54f785aef6ac (sysbus: Fix latent bug with onboard devices) 5/12 Checking commit 8e6aa0c7e85c (vl: Improve legibility of BlockdevOptions queue) 6/12 Checking commit 4fd41657da38 (vl: Factor configure_blockdev() out of main()) WARNING: Block comments use a leading /* on a separate line #25: FILE: vl.c:1207: + /* If the currently selected machine wishes to override the units-per-bus WARNING: Block comments use a trailing */ on a separate line #26: FILE: vl.c:1208: + * property of its default HBA interface type, do so now. */ total: 0 errors, 2 warnings, 83 lines checked Patch 6/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/12 Checking commit ac5ff6df764f (vl: Create block backends before setting machine properties) 8/12 Checking commit 06dfc824b9ea (pflash_cfi01: Add pflash_cfi01_get_blk() helper) 9/12 Checking commit 5ed81089c86b (pc_sysfw: Remove unused PcSysFwDevice) 10/12 Checking commit 2781f626cf40 (pc_sysfw: Pass PCMachineState to pc_system_firmware_init()) 11/12 Checking commit 7b348eb43865 (pc: Support firmware configuration with -blockdev) WARNING: line over 80 characters #372: FILE: hw/i386/pc_sysfw.c:328: + error_report("pflash with kvm requires KVM readonly memory support"); total: 0 errors, 1 warnings, 315 lines checked Patch 11/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/12 Checking commit e159d1ed0de2 (docs/interop/firmware.json: Prefer -machine to if=pflash) ERROR: trailing whitespace #49: FILE: docs/interop/firmware.json:239: +# $ total: 1 errors, 0 warnings, 33 lines checked Patch 12/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
