Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: [email protected] Subject: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' b8003b82de docs/interop/firmware.json: Prefer -machine to if=pflash 4694b306ec pc: Support firmware configuration with -blockdev 93bc292290 pc_sysfw: Pass PCMachineState to pc_system_firmware_init() c3d5fb15cd pc_sysfw: Remove unused PcSysFwDevice 3787c376e2 pflash_cfi01: Add pflash_cfi01_get_blk() helper 4fbc3cfda2 vl: Create block backends before setting machine properties 63a9dfee66 vl: Factor configure_blockdev() out of main() 5578280abb vl: Improve legibility of BlockdevOptions queue 0fddf3eb0e sysbus: Fix latent bug with onboard devices 915ec2186e vl: Fix latent bug with -global and onboard devices a6cf369849 qom: Move compat_props machinery from qdev to QOM facb673f93 qdev: Fix latent bug with compat_props and onboard devices === OUTPUT BEGIN === 1/12 Checking commit facb673f9389 (qdev: Fix latent bug with compat_props and onboard devices) 2/12 Checking commit a6cf3698492d (qom: Move compat_props machinery from qdev to QOM) 3/12 Checking commit 915ec2186e86 (vl: Fix latent bug with -global and onboard devices) 4/12 Checking commit 0fddf3eb0e35 (sysbus: Fix latent bug with onboard devices) 5/12 Checking commit 5578280abbef (vl: Improve legibility of BlockdevOptions queue) 6/12 Checking commit 63a9dfee6675 (vl: Factor configure_blockdev() out of main()) WARNING: Block comments use a leading /* on a separate line #26: FILE: vl.c:1207: + /* If the currently selected machine wishes to override the units-per-bus WARNING: Block comments use a trailing */ on a separate line #27: FILE: vl.c:1208: + * property of its default HBA interface type, do so now. */ total: 0 errors, 2 warnings, 83 lines checked Patch 6/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/12 Checking commit 4fbc3cfda201 (vl: Create block backends before setting machine properties) 8/12 Checking commit 3787c376e2ce (pflash_cfi01: Add pflash_cfi01_get_blk() helper) 9/12 Checking commit c3d5fb15cd25 (pc_sysfw: Remove unused PcSysFwDevice) 10/12 Checking commit 93bc29229007 (pc_sysfw: Pass PCMachineState to pc_system_firmware_init()) 11/12 Checking commit 4694b306ec66 (pc: Support firmware configuration with -blockdev) WARNING: line over 80 characters #372: FILE: hw/i386/pc_sysfw.c:328: + error_report("pflash with kvm requires KVM readonly memory support"); total: 0 errors, 1 warnings, 315 lines checked Patch 11/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/12 Checking commit b8003b82deab (docs/interop/firmware.json: Prefer -machine to if=pflash) ERROR: trailing whitespace #49: FILE: docs/interop/firmware.json:239: +# $ total: 1 errors, 0 warnings, 33 lines checked Patch 12/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
