On 3/13/19 9:25 AM, Kevin Wolf wrote: > We were trying to check whether bdrv_open_blockdev_ref() returned > success, but accidentally checked the wrong variable. Spotted by > Coverity (CID 1399703). > > Signed-off-by: Kevin Wolf <[email protected]> > --- > block/qcow2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <[email protected]> > > diff --git a/block/qcow2.c b/block/qcow2.c > index 0fc9b0561e..20aba3a4d6 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -3073,7 +3073,7 @@ qcow2_co_create(BlockdevCreateOptions *create_options, > Error **errp) > goto out; > } > data_bs = bdrv_open_blockdev_ref(qcow2_opts->data_file, errp); > - if (bs == NULL) { > + if (data_bs == NULL) { > ret = -EIO; > goto out; > } > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
