On 5/7/19 1:36 PM, Max Reitz wrote: > We kept old_stderr specifically so we could keep emitting error message > on stderr. However, qemu_daemon() closes stderr. Therefore, we need to > dup() stderr to old_stderr before invoking qemu_daemon(). > > Signed-off-by: Max Reitz <[email protected]> > --- > As I hinted at in the cover letter, I am not sure whether this is truly > a bug or whether the current behavior is intentional. So if you > disagree with me on this patch, you are welcome to suggest an > alternative.
Looks to me like a bug fix, for a problem present since commit c1f8fdc3 added old_stderr in 2011. > > I personally can see two: > (1) Add a --log option for a file to store the server's messages in. > Seems a bit cumbersome to me. > > (2) Add a --keep-stderr option, which specifically enables this behavior > here. Without this option we keep the old behavior. The approach done here is simplest, I wouldn't worry about your two alternatives. Reviewed-by: Eric Blake <[email protected]> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
