On 4/9/20 10:30 AM, Markus Armbruster wrote:
When opts_parse() sets @invalidp to true, qemu_opts_parse_noisily()
uses has_help_option() to decide whether to print help. This parses
the input string a second time, in a slightly different way.
Easy to avoid: replace @invalidp by @help_wanted.
Signed-off-by: Markus Armbruster <[email protected]>
---
util/qemu-option.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
- opts = opts_parse(list, params, permit_abbrev, false, &invalidp, &err);
+ opts = opts_parse(list, params, permit_abbrev, false, &help_wanted, &err);
if (err) {
- if (invalidp && has_help_option(params)) {
+ if (help_wanted) {
Yep, that is cleaner. Should there be testsuite coverage changing as a
result of this?
Reviewed-by: Eric Blake <[email protected]>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
