On 4/30/20 8:30 AM, Kevin Wolf wrote:
In order to avoid bitrot in the zero cluster code in VMDK, enable
zero_grained=on by default for the tests.
Here, you spell it zero_grained=on,
Signed-off-by: Kevin Wolf <[email protected]>
---
tests/qemu-iotests/059 | 6 +++---
tests/qemu-iotests/check | 3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
So you're changing the default for better coverage and speed, but
ensuring that 59 still covers the (slower) zero_grained=off. Seems
reasonable.
Reviewed-by: Eric Blake <[email protected]>
+++ b/tests/qemu-iotests/check
@@ -546,6 +546,9 @@ fi
if [ "$IMGFMT" == "luks" ] && ! (echo "$IMGOPTS" | grep "iter-time=" >
/dev/null); then
IMGOPTS=$(_optstr_add "$IMGOPTS" "iter-time=10")
fi
+if [ "$IMGFMT" == "vmdk" ] && ! (echo "$IMGOPTS" | grep "zeroed_grain=" >
/dev/null); then
Here, zeroed_grain=. Which is it?
+ IMGOPTS=$(_optstr_add "$IMGOPTS" "zeroed_grain=on")
As a native speaker, my inclination is zero_grained; but I don't know
the VMDK spec well enough to know if this is something in the spec, or
just a term that qemu invented. And since we already have existing
usage of one spelling, switching the spelling now would require a
deprecation period and is separate from this patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
