On 6/2/20 11:05 AM, Eric Blake wrote:

[I hit send too soon...]

+++ b/tests/qemu-iotests/qcow2.py
@@ -6,19 +6,36 @@ import string
  class QcowHeaderExtension:
+    QCOW2_EXT_MAGIC_BACKING_FORMAT = 0xE2792ACA
+    QCOW2_EXT_MAGIC_FEATURE_TABLE = 0x6803f857

Why the inconsistency between capitalization in these constants?

At least it matches the inconsistency in docs/interop/qcow2.txt; a patch to fix that wouldn't hurt.


Reviewed-by: Eric Blake <[email protected]>


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


Reply via email to